Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atmospheric Particle Scoop collects mainly Liquids, but doesn't say so anywhere in the description #732

Open
kriber82 opened this issue Mar 15, 2024 · 1 comment

Comments

@kriber82
Copy link

I built an atmospheric particle scoop ship for Kerbin and had a very hard time figuring out how to set it up correctly.

The only gas I could collect by trial and error with changing the content type of my IST2501gas tanks was Argon.
Only when reading the source code, I found out, that the scoop mainly collects liquids.

No idea, why collecting Argon works, as the definition in AtmosphereProcessor.cs:198 also references ArgonLqd...

If collecting Liquids is intended, I would suggest adding this to the Part description in the VAB (either in the text or in the function description).

If collecting Liquids is not intended, the rescource names in AtmopsphereProcessor.cs (starting at line 195) should probably be changed to ResourceSettings.Config.*Gas.

@yzmengnan
Copy link

yzmengnan commented Mar 15, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants