Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Support for Alternative S3 Storage Providers in Test Reports Slack notifications links #122

Closed
andrzejmikolajczakds opened this issue Jun 21, 2024 · 3 comments

Comments

@andrzejmikolajczakds
Copy link
Contributor

Summary

We would like to request the capability to run tests and obtain reports from various S3 storage providers.

Currently, it is possible to send reports files to other S3 providers by using cloudStorageSpec.provider="aws" and setting the RCLONE_* environment variables. However, the Slack notifications contain a link with the "s3.amazonaws.com" host, which is specific to AWS.

We propose an enhancement to allow the Slack notification links to support others than AWS S3 providers.

I am willing to contribute to this improvement in the gatling-operator.

Thank you for considering this request.

@kane8n
Copy link
Contributor

kane8n commented Jun 24, 2024

@andrzejmikolajczakds
I understand that this is a proposal to support S3 compatible storage as described in https://rclone.org/s3/#configuration.
I have no particular objection and would appreciate your contribution!

I am willing to contribute to this improvement in the gatling-operator.

We would greatly appreciate your contribution!
Please submit a Pull Request, and we will review it!

@andrzejmikolajczakds
Copy link
Contributor Author

Hi @kane8n,

I've created a PR. I'm not sure if you're receiving notifications for new PRs in the repository, so I wanted to give you a heads-up.

Thanks!

@kane8n
Copy link
Contributor

kane8n commented Jul 4, 2024

@andrzejmikolajczakds
Merge the PullRequest and close this issue.
It has been released in v0.9.9.
Thanks for your contribution!

@kane8n kane8n closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants