Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align schema validation rules in pydantic models with JSON Schema #20

Open
fmigneault opened this issue Oct 3, 2024 · 0 comments
Open
Assignees
Labels
enhancement New feature or request schema Issues related to the JSON schema of the extension. stac-model Issues specifically related to the utility Python package.

Comments

@fmigneault
Copy link
Collaborator

@rbavery cloned issue crim-ca/mlm-extension#36 on 2024-09-13:

🚀 Feature Request

I'm finding that the JSON Schema has more specific (and sensible) rules for a number of fields. So far I'm seeing

framework_version: must follow numerical structure with alphanumerics allowed at the end

dim_order: duplicates not allowed

I can make the updates in the pydantic models.

🔉 Motivation

When a user of stac_model tries to construct the MLM metadata as JSON, they might not follow all the rules in the JSON Schema but the pydantic models won't raise errors. This will cause a problem when the user tries to validate the pystac item against the schema.

📡 Alternatives

Keep as is.

@fmigneault fmigneault added the enhancement New feature or request label Oct 3, 2024
@fmigneault fmigneault added stac-model Issues specifically related to the utility Python package. schema Issues related to the JSON schema of the extension. labels Oct 3, 2024
@rbavery rbavery self-assigned this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request schema Issues related to the JSON schema of the extension. stac-model Issues specifically related to the utility Python package.
Projects
None yet
Development

No branches or pull requests

2 participants