Allowing to fix the request base URL via an env var #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadomski
reviewed
Jun 22, 2023
| from starlette.requests import Request | ||
|
|
||
|
|
||
| def get_base_url(request: Request) -> str: | ||
| """Get base URL with respect of APIRouter prefix.""" | ||
| if base_url := os.environ.get("REQUEST_BASE_URL"): | ||
| return base_url | ||
|
|
||
| app = request.app | ||
| if not app.state.router_prefix: |
There was a problem hiding this comment.
Was there a reason to not use the same mechanism as router_prefix, i.e. add a new base_url: Optional[str] attribute to the app state?
|
As for #636, I'm not convince we need this. If the baseurl is not properly returned by starlette it usually mean there is a configuration issue in the proxy 🤔 |
|
Should we close this for now? |
|
@jonhealy1 IMO yes |
|
closing ..... feel free to reopen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
A new env var
REQUEST_BASE_URLis introduced to fix the base URL to the supplied value. When this variable is not set, the usual way of determining the base URL is used.PR Checklist:
pre-commithooks pass locallymake test)make docs)