Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License #1

Closed
jcarpent opened this issue Oct 8, 2019 · 13 comments
Closed

License #1

jcarpent opened this issue Oct 8, 2019 · 13 comments
Assignees

Comments

@jcarpent
Copy link
Contributor

jcarpent commented Oct 8, 2019

The original mention of the license of the code is largely missing.
The code is a copy paster or former code by Andrea.

This should be fixed before any formal release I would say.

@nim65s
Copy link
Contributor

nim65s commented Oct 9, 2019

Hi,

The release v1.0.0 is imminent. The license says

Stack Of Tasks development team

@andreadelprete: do you want to add anything ?

@jcarpent
Copy link
Contributor Author

jcarpent commented Oct 9, 2019

The original license is coming from people of Eigen. Please copy/past where it is required.

@jcarpent
Copy link
Contributor Author

jcarpent commented Oct 9, 2019

I think @jmirabel may provide some hints about the original license

@jmirabel
Copy link

jmirabel commented Oct 9, 2019

Here are the pieces of information I could gather:

About the license of quadprog, I traced back the origin of the file:

To conclude, I think we can safely assume quadprog is LGPL.

@jcarpent
Copy link
Contributor Author

jcarpent commented Oct 9, 2019

So the core code of this module should be LGPL and not BSD as currently mentioned.

@jmirabel
Copy link

jmirabel commented Oct 9, 2019

I think it should be GPL, except if Gael Guennebaud (and maybe Benjamin Stephens) agrees to change this to LGPL.

@andreadelprete
Copy link

Very good job backtracking the origin of this piece of code @jmirabel !
I confirm that this matches what I knew about it, and that I started my development from the version of Benjamin Stephens.

@nim65s
Copy link
Contributor

nim65s commented Oct 9, 2019

Thanks for that job :D

From the link in #2, it looks like Gael Guennebaud latest version is LGPL, so I think that we can use that.

@jmirabel
Copy link

jmirabel commented Oct 9, 2019

I think you can assume Gael Guennebaud has already accepted the LGPL licence.

@gabrielebndn
Copy link
Contributor

Hi everybody,
so are we going for LGPL?
Concretely, what action should we take and where should the licence info go?
Is it enough to change the LICENSE file?
@jcarpent, what do you think?
@nim65s, could you take care of it?

@nim65s
Copy link
Contributor

nim65s commented Oct 10, 2019

According to GNU, for the LGPL (and their other licenses), in addition of the main file, we have to put a license notice in each and every file.

I hate that, but will do it.

@nim65s nim65s self-assigned this Oct 10, 2019
@nim65s
Copy link
Contributor

nim65s commented Oct 24, 2019

Fixed and released. Thank you all on this issue :)

@nim65s nim65s closed this as completed Oct 24, 2019
@gabrielebndn
Copy link
Contributor

Thanks @nim65s :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants