Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/*.py.cmake files #21

Open
nim65s opened this issue May 11, 2020 · 2 comments
Open

tests/*.py.cmake files #21

nim65s opened this issue May 11, 2020 · 2 comments
Assignees

Comments

@nim65s
Copy link
Contributor

nim65s commented May 11, 2020

Hi,

We have some *.py.cmake files. I think this could easily be avoided, and should be. Plus it is currently broken because of a typo.

I can handle katana_holding.py.cmake, but for appli-test-simple-seq-play.py.cmake, there is also a appli-test-simple-seq-play.py available. @olivier-stasse : can you confirm that I can remove appli-test-simple-seq-play.py.cmake as appli-test-simple-seq-play.py seems to be more recent and used instead ?

@olivier-stasse
Copy link
Member

Thanks for picking this up.
appli-test-simple-seq-play.py should not be used as it has hardcoded path value.
This a left over of tests.
The problem is to find where on the robot the files are located.
rospack would be the easiest way to handle the issue.

@nim65s
Copy link
Contributor Author

nim65s commented May 15, 2020

Thanks for your answer. But I would like to avoid rospack, as I don't see the need for ROS to find paths to files. Moreover, rospack doesn't work on 16.04.
To address the issue of hardcoded path, we can either use CMake, or a strategy similar to stack-of-tasks/talos_integration_tests#6

@nim65s nim65s self-assigned this May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants