Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using pkg.pr.new in the Babel repo #321

Open
nicolo-ribaudo opened this issue Jan 28, 2025 · 1 comment
Open

Using pkg.pr.new in the Babel repo #321

nicolo-ribaudo opened this issue Jan 28, 2025 · 1 comment

Comments

@nicolo-ribaudo
Copy link

Hello!

I was looking at pkg.pr.new, and wondering if it would be possible for me to use it in https://github.com/babel/babel/.

We have a few of uncommon setups, so I'm not 100% sure that we would be actually able to do it:

  • We have 150 packages, but usually our consumers have at most a couple in their package.json. A pull request can affect package babel-A, the user depends on package babel-B, package babel-B depends on package babel-A. Ideally there would be a way for the user to test the changes even if they are not in the package that they are directly depending on.
  • We currently publish both Babel 7 and Babel 8-alpha/beta releases from the same branch. Any pull request can affect either one, the other, or both (usually it's both, but it's probably possible to run some static analysis to tell if it's only going to affect one). Ideally, for each PR we would just publish previews for both versions.
  • We don't simply run npm/yarn/pnpm/lerna publish to publish packages. We have a custom plugin for Yarn that basically builds the tarball files (https://github.com/nicolo-ribaudo/yarn-plugin-babel-release-tool), and then Yarn will only upload the tarballs to the registry without actually creating them.
  • On each PR, as part of our CI, we actually already publish all the packages to a local Verdaccio registry. This might simplify things?

Do you see any blocker, or can you point me in the right direction? :)

@Aslemammad
Copy link
Member

ok, this message made me happy! i can say finally now :)

for now, pkg.pr.new relies on pnpm pack / npm pack but if you want to upload your own generated tarball (which makes me think, only trusted entities can do in pkg.pr.new, via the whitelist), maybe we can introduce a --tarball option to pkg.pr.new?

i'd love to hear your thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants