Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

Withdrawal payloads should not be replayable #31

Open
netrome opened this issue Aug 1, 2023 · 2 comments
Open

Withdrawal payloads should not be replayable #31

netrome opened this issue Aug 1, 2023 · 2 comments
Assignees
@stjepangolemac
Labels
enhancement New feature or request stale

Comments

@netrome
Copy link
Contributor

netrome commented Aug 1, 2023 •
edited
Loading

In the current design, anyone could replay a withdrawal request and cause the protocol to withdraw someone else's sBTC. We should not allow this.

Definition of done

The protocol has been updated so that withdrawal payloads are not replayable.
@netrome netrome added enhancement New feature or request draft and removed draft labels Aug 1, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Stacks Core Eng Aug 4, 2023
@netrome netrome removed their assignment Aug 7, 2023
@netrome netrome mentioned this issue Aug 31, 2023
Closed
@netrome
Copy link
Contributor Author

netrome commented Aug 31, 2023

A simple solution to this would be to sign the the txid of the first input to the sBTC transaction in addition to the amount and recipient scriptPubKey in the withdrawal data.

@stale Stale
Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stjepangolemac stjepangolemac

Labels
enhancement New feature or request stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stjepangolemac @netrome