Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have miners report their version #5517

Closed
aldur opened this issue Nov 28, 2024 · 6 comments
Closed

Have miners report their version #5517

aldur opened this issue Nov 28, 2024 · 6 comments

Comments

@aldur
Copy link
Contributor

aldur commented Nov 28, 2024

Signers broadcast their version as part of their standard operations. This makes it easy to measure how release updates are adopted across the network.

This feature proposes adding the same to miners.

Describe the solution you'd like
Ideally, miners would report their version when communicating with the rest of the network. They could also do that when mining a new block (e.g. in a memo or similar).

Additional context
I think miners right now report something related to the StacksEpochId, which does not change for minor/point releases.

pub enum StacksEpochId {

@jcnelson
Copy link
Member

jcnelson commented Nov 28, 2024 via email

@diwakergupta
Copy link
Member

We discussed this at length in the past and determined it was a privacy violation.

Can you link to any prior written discussion and decision on this? Also, even if a decision had been reached in the past, that does not mean the decision can't or shouldn't be revisited. Needing to know if miners have upgraded is a recurring issue and IMO it merits having a proper solution in place.

One thought: version reporting could be configurable, on by default and if miners don't want it, they can just turn the reporting off.

@jcnelson
Copy link
Member

jcnelson commented Dec 2, 2024

It was discussed in one of the past blockchain meetings years ago. Your suggestion of making it configurable was also discussed, and ultimately dropped in favor of using the block version byte.

I continue to stand by the status quo. It addresses the problem at hand -- knowing whether or not miners are (likely) running a minimum node version.

Also, I reject the premise of adding telemetry surreptitiously and making it opt-out. Not only is the legality questionable (doesn't this violate the GDPR?), but I also think it's unethical. No one asked to be spied on.

@aldur
Copy link
Contributor Author

aldur commented Dec 2, 2024

What we have done instead is to bump the block version (which is not consensus-critical), so we can tell what the minimum version of the miner is.

Are there constraints around bumping this e.g. on point releases?

@jcnelson
Copy link
Member

jcnelson commented Dec 2, 2024 via email

@aldur
Copy link
Contributor Author

aldur commented Dec 3, 2024

Closing this for the time being -- we might revisit it later.

@aldur aldur closed this as completed Dec 3, 2024
@github-project-automation github-project-automation bot moved this from Status: 🆕 New to Status: ✅ Done in Stacks Core Eng Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Status: ✅ Done
Development

No branches or pull requests

3 participants