-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have miners report their version #5517
Comments
We discussed this at length in the past and determined it was a privacy
violation.
What we have done instead is to bump the block version (which is not
consensus-critical), so we can tell what the minimum version of the miner
is.
…On Thu, Nov 28, 2024, 8:04 AM Adriano Di Luzio ***@***.***> wrote:
Signers broadcast their version as part of their standard operations. This
makes it easy to measure how release updates are adopted across the network.
This feature proposes adding the same to miners.
*Describe the solution you'd like*
Ideally, miners would report their version when communicating with the
rest of the network. They could also do that when mining a new block (e.g.
in a memo or similar).
*Additional context*
I *think* miners right now report something related to the StacksEpochId,
which does not change for minor/point releases.
https://github.com/stacks-network/stacks-core/blob/7267cd0fd58bdcf94c7f32f411ea162dd9a83b36/stacks-common/src/types/mod.rs#L74
—
Reply to this email directly, view it on GitHub
<#5517>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADQJK5P2TTB75554OQHRF32C4IFDAVCNFSM6AAAAABSVC6UW2VHI2DSMVQWIX3LMV43ASLTON2WKOZSG4YDEMBYHE3DQNY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Can you link to any prior written discussion and decision on this? Also, even if a decision had been reached in the past, that does not mean the decision can't or shouldn't be revisited. Needing to know if miners have upgraded is a recurring issue and IMO it merits having a proper solution in place. One thought: version reporting could be configurable, on by default and if miners don't want it, they can just turn the reporting off. |
It was discussed in one of the past blockchain meetings years ago. Your suggestion of making it configurable was also discussed, and ultimately dropped in favor of using the block version byte. I continue to stand by the status quo. It addresses the problem at hand -- knowing whether or not miners are (likely) running a minimum node version. Also, I reject the premise of adding telemetry surreptitiously and making it opt-out. Not only is the legality questionable (doesn't this violate the GDPR?), but I also think it's unethical. No one asked to be spied on. |
Are there constraints around bumping this e.g. on point releases? |
It's done on an as-needed basis, but certainly not every release. That
would defeat the point.
…On Mon, Dec 2, 2024, 12:04 PM Adriano Di Luzio ***@***.***> wrote:
What we have done instead is to bump the block version (which is not
consensus-critical), so we can tell what the minimum version of the miner
is.
Are there constraints around bumping this e.g. on point releases?
—
Reply to this email directly, view it on GitHub
<#5517 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADQJK5LNXIZTAZU5JJ2UQT2DSHI7AVCNFSM6AAAAABSVC6UW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJSGE3TINJTGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Closing this for the time being -- we might revisit it later. |
Signers broadcast their version as part of their standard operations. This makes it easy to measure how release updates are adopted across the network.
This feature proposes adding the same to miners.
Describe the solution you'd like
Ideally, miners would report their version when communicating with the rest of the network. They could also do that when mining a new block (e.g. in a memo or similar).
Additional context
I think miners right now report something related to the
StacksEpochId
, which does not change for minor/point releases.stacks-core/stacks-common/src/types/mod.rs
Line 74 in 7267cd0
The text was updated successfully, but these errors were encountered: