Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[signer] Add block_proposal_max_age_secs signer configuration to drop old proposals without further processing #5549

Merged
merged 7 commits into from
Dec 12, 2024
+185 −32
Merged

[signer] Add block_proposal_max_age_secs signer configuration to drop old proposals without further processing #5549

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
83a032f
Added block_proposal_max_age_secs signer configuration to drop old pr…
jferrant Dec 9, 2024
738845e
Fix test
jferrant Dec 9, 2024
4497377
Merge branch 'develop' of https://github.com/stacks-network/stacks-co…
jferrant Dec 10, 2024
66bc4ab
Make sure NakamotoBlock has valid header timestamp in signer v0 tests
jferrant Dec 10, 2024
cc2af4e
Should not use the nakamoto blocks mined test observer heuristic in m…
jferrant Dec 10, 2024
a78f818
CRC: add signer_signature_hash to warn message for dropping old block…
jferrant Dec 10, 2024
016a63f
CRC: replace signer_signature_hash with signer_sighash in warn log
jferrant Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions stacks-signer/src/v0/signer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,7 @@ impl Signer {
{
// Block is too old. Drop it with a warning. Don't even bother broadcasting to the node.
warn!("{self}: Received a block proposal that is more than {} secs old. Ignoring...", self.block_proposal_max_age_secs;
"signer_signature_hash" => %block_proposal.block.header.signer_signature_hash(),
jferrant marked this conversation as resolved.
Show resolved Hide resolved
"block_id" => %block_proposal.block.block_id(),
jferrant marked this conversation as resolved.
Show resolved Hide resolved
"block_height" => block_proposal.block.header.chain_length,
"burn_height" => block_proposal.burn_height,
Expand Down
Loading