Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Resampler Flag case sensitive #1315

Open
1 task done
Elem-draws opened this issue Nov 3, 2024 · 2 comments
Open
1 task done

Make the Resampler Flag case sensitive #1315

Elem-draws opened this issue Nov 3, 2024 · 2 comments

Comments

@Elem-draws
Copy link

Acknowledgement

  • I have read Getting-Started and FAQ

🐛 Describe the bug

Moresampler requires expressions of its own, which have to be manually added. The problem occurs when I try to add the distortion flag ("MD") after adding the dryness flag ("Md").

Explains how to reproduce the bug

  1. Open openUTAU
  2. Choose singer
  3. Choose Moresampler as the resampler
  4. Open the track and add expressions
  5. Add the dryness flag ("Md")
  6. Add the distortion flag ("MD")
  7. Get the error

OS & Version

Windows 10

Logs

An item with the same key has already been added. Key: md

System.ArgumentException: An item with the same key has already been added. Key: md
at System.Collections.Generic.Dictionary2.TryInsert(TKey key, TValue value, InsertionBehavior behavior) at System.Collections.Generic.Dictionary2.Add(TKey key, TValue value)
at System.Linq.Enumerable.ToDictionary[TSource,TKey](TSource[] source, Func2 keySelector, IEqualityComparer1 comparer)
at System.Linq.Enumerable.ToDictionary[TSource,TKey](IEnumerable1 source, Func2 keySelector, IEqualityComparer1 comparer) at System.Linq.Enumerable.ToDictionary[TSource,TKey](IEnumerable1 source, Func`2 keySelector)
at OpenUtau.Core.ConfigureExpressionsCommand.Execute() in C:\projects\openutau\OpenUtau.Core\Commands\ProjectCommands.cs:line 169
at OpenUtau.Core.DocManager.ExecuteCmd(UCommand cmd) in C:\projects\openutau\OpenUtau.Core\DocManager.cs:line 244
at OpenUtau.App.ViewModels.ExpressionsViewModel.Apply() in C:\projects\openutau\OpenUtau\ViewModels\ExpressionsViewModel.cs:line 152
at OpenUtau.App.Views.ExpressionsDialog.ApplyButtonClicked(Object sender, RoutedEventArgs _) in C:\projects\openutau\OpenUtau\Views\ExpressionsDialog.axaml.cs:line 15

0.1.529.0

@BagelHero
Copy link
Contributor

BagelHero commented Nov 3, 2024

Huh, odd... well, good thing we have a workaround, you can include manifests that allow you to use the big "load expressions from resampler" button instead so you don't need to add the expressions manually for every project.

https://github.com/stakira/OpenUtau/wiki/Resamplers-and-Wavtools#resampler-manifest

The example provided here is for moresampler (we have more premade ones available too), but importantly it seems if you use this it WILL differentiate the flags. The issue is just when adding them in-editor it seems-- which is of course still an issue to address. Thank you for the report!

@Elem-draws
Copy link
Author

The manifest gets the job done AND saves me time on adding expressions, rather than doing manually! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants