Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Artworks should store an Ebook ID #446

Open
acabal opened this issue Dec 18, 2024 · 0 comments
Open

Artworks should store an Ebook ID #446

acabal opened this issue Dec 18, 2024 · 0 comments
Assignees
@colagrosso
Labels
enhancement New feature or request

Comments

@acabal
Copy link
Member

acabal commented Dec 18, 2024

In the database, we identify Artworks with the EbookUrl. But, now that we have placeholder ebooks available artworks should be linked to ebooks with an EbookId.

So, we should add an EbookId column to the Artworks table, and populate that with the actual ebook ID of the ebook.

The user can still enter a URL to identify an ebook, but when validating we resolve that URL to an ebook ID.

If an ebook ID doesn't exist for that URL, throw an error, and the admin will have to add a placeholder first.

Also see Ebook.php line 141 which will have to be updated to use Artwork.EbookId.
@acabal acabal added the enhancement New feature or request label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colagrosso colagrosso

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@colagrosso @acabal