-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added the log size increase and update the documentation for the signatures #1745
Conversation
sushmanthreddy
commented
Nov 3, 2024
- Updating the documentation for th signatures
- Increased the logo size and moved the communities and faq right side for better design
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but left some comments!
- '' : '' | ||
- '' : '' | ||
- '' : '' | ||
- '' : '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentional? What is this doing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah @okhat told me to do that way to create space between tutorial and community ,FAQ
This just adds the space between them
@@ -1,4 +1,4 @@ | |||
site_name: DSPy | |||
site_name: DSPy Documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@okhat might be able to judge this better but I think we can keep this as DSPy? It's a mix of docs and landing page and everything in between imo
@@ -0,0 +1,33 @@ | |||
/* Custom styles for logo */ | |||
.md-logo { | |||
width: auto !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid !important whenever you can and make sure this file doesn't break existing style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@okhat has told me to do, this way actually for better design
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea I didn't mean now, but in case these styles overlap they tend to break. Hmm usually !important
is something is avoid unless absolutely necessary. But I think it's one :)