Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the log size increase and update the documentation for the signatures #1745

Merged
merged 5 commits into from
Nov 8, 2024

Conversation

sushmanthreddy
Copy link
Contributor

  1. Updating the documentation for th signatures
  2. Increased the logo size and moved the communities and faq right side for better design

Copy link
Collaborator

@krypticmouse krypticmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but left some comments!

- '' : ''
- '' : ''
- '' : ''
- '' : ''
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional? What is this doing?

Copy link
Contributor Author

@sushmanthreddy sushmanthreddy Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah @okhat told me to do that way to create space between tutorial and community ,FAQ
This just adds the space between them

@@ -1,4 +1,4 @@
site_name: DSPy
site_name: DSPy Documentation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@okhat might be able to judge this better but I think we can keep this as DSPy? It's a mix of docs and landing page and everything in between imo

@@ -0,0 +1,33 @@
/* Custom styles for logo */
.md-logo {
width: auto !important;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid !important whenever you can and make sure this file doesn't break existing style.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah doesn't break any existing style actually it just makes logo bigger
Screenshot 2024-11-06 at 5 19 54 PM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@okhat has told me to do, this way actually for better design

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I didn't mean now, but in case these styles overlap they tend to break. Hmm usually !important is something is avoid unless absolutely necessary. But I think it's one :)

@okhat okhat merged commit 92c4404 into stanfordnlp:main Nov 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants