This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Updated Chapter 2 #233
Merged
Updated Chapter 2 #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoobie
suggested changes
Oct 25, 2023
There was a problem hiding this comment.
Hey @OkoliEvans Looks good. I made some suggestions and gave you some tech writing tips.
I did not verify the procedure though, try to make sure that someone goes through the steps. It does sound right to me, though. I wrote a post called Getting started using Starknet, and as I recall, you captured the steps correctly.
|
All changes have been effected @stoobie |
stoobie
reviewed
Oct 26, 2023
stoobie
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
@OkoliEvans I made one tiny change. As far as the text, LGTM.
omarespejel
approved these changes
Oct 26, 2023
|
Thank you for the PR @OkoliEvans! And @stoobie for the review! |
Happy to learn and contribute |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on issues about confusion on how to deploy account, I updated the book to include the steps for setting up and deploying accounts on Braavos and Argent X. @omarespejel @stoobie