Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(native_blockifier): support receiving L1 Data Gas #2343

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TzahiTaub
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@TzahiTaub TzahiTaub marked this pull request as ready for review November 28, 2024 12:51
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Nov 28, 2024

@TzahiTaub TzahiTaub force-pushed the 11-28-feature_native_blockifier_support_receiving_l1_data_gas branch from 70e441d to db02f22 Compare November 28, 2024 12:53
@TzahiTaub TzahiTaub changed the title feature(native_blockifier): support receiving L1 Data Gas feat(native_blockifier): support receiving L1 Data Gas Nov 28, 2024
@TzahiTaub TzahiTaub force-pushed the 11-28-feature_native_blockifier_support_receiving_l1_data_gas branch from db02f22 to 961666a Compare November 28, 2024 13:04
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 43.82%. Comparing base (e3165c4) to head (961666a).
Report is 626 commits behind head on main.

Files with missing lines Patch % Lines
...kifier_reexecution/src/state_reader/serde_utils.rs 0.00% 1 Missing and 2 partials ⚠️
crates/native_blockifier/src/py_transaction.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2343      +/-   ##
==========================================
+ Coverage   40.10%   43.82%   +3.71%     
==========================================
  Files          26      221     +195     
  Lines        1895    25615   +23720     
  Branches     1895    25615   +23720     
==========================================
+ Hits          760    11225   +10465     
- Misses       1100    13629   +12529     
- Partials       35      761     +726     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @TzahiTaub)


a discussion (no related file):
py side PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants