Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starknet_consensus_manager): set proposer address in propose block input #2346

Open
wants to merge 1 commit into
base: arni/batcher/block_builder_factory/set_use_kzg_da_in_build_block_input
Choose a base branch
from

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 17.90%. Comparing base (ef924ab) to head (8049c64).

Files with missing lines Patch % Lines
...nsus_orchestrator/src/papyrus_consensus_context.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                                            Coverage Diff                                             @@
##           arni/batcher/block_builder_factory/set_use_kzg_da_in_build_block_input    #2346      +/-   ##
==========================================================================================================
- Coverage                                                                   27.16%   17.90%   -9.27%     
==========================================================================================================
  Files                                                                         121      119       -2     
  Lines                                                                       13932    13915      -17     
  Branches                                                                    13932    13915      -17     
==========================================================================================================
- Hits                                                                         3785     2491    -1294     
- Misses                                                                       9811    11153    +1342     
+ Partials                                                                      336      271      -65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArniStarkware
Copy link
Contributor Author

crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs line 293 at r1 (raw file):

            None => true,
        };
        if condition {

remove, this is not a part of this PR.

Code quote:

    ) {
        let condition = match self.current_height {
            Some(h) => h < height,
            None => true,
        };
        if condition {

@ArniStarkware ArniStarkware changed the title chore(consensus): set proposer address in propose block input chore(starknet_consensus_manager): set proposer address in propose block input Dec 1, 2024
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_use_kzg_da_in_build_block_input branch from ef924ab to f3ada2d Compare December 1, 2024 12:53
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_propser_address_in_build_block_input branch from 8049c64 to 350ca29 Compare December 1, 2024 13:00
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_use_kzg_da_in_build_block_input branch from f3ada2d to f84a046 Compare December 1, 2024 13:52
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_propser_address_in_build_block_input branch from 350ca29 to d3ead1e Compare December 1, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants