Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(consensus): enable failed proposal building #2349

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

asmaastarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 9.75%. Comparing base (e3165c4) to head (897e2de).
Report is 628 commits behind head on main.

Files with missing lines Patch % Lines
...g/papyrus_consensus/src/single_height_consensus.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #2349       +/-   ##
==========================================
- Coverage   40.10%   9.75%   -30.35%     
==========================================
  Files          26      87       +61     
  Lines        1895   10352     +8457     
  Branches     1895   10352     +8457     
==========================================
+ Hits          760    1010      +250     
- Misses       1100    9305     +8205     
- Partials       35      37        +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@matan-starkware matan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @asmaastarkware)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants