Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: MerkleProver::commit doesn't panic if the columns are not sorted in descending order #660

Open
weikengchen opened this issue Jun 10, 2024 · 0 comments

Comments

@weikengchen
Copy link
Contributor

The comment of the commit method of MerkleProver says (https://github.com/starkware-libs/stwo/blob/dev/crates/prover/src/core/vcs/prover.rs#L24):

/// # Panics
///
/// This function will panic if the columns are not sorted in descending order or if the columns
/// vector is empty.

However, this doesn't seem to be the case, as the method doesn't panic, but indeed, it sorts the input column vectors through "sorted_by_key" (with a Reverse).

This comment needs modifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant