Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x] Filter out empty values in keyed array field #11138

Open
wants to merge 2 commits into
base: 5.x
Choose a base branch
from
Open

[5.x] Filter out empty values in keyed array field #11138

wants to merge 2 commits into from
+5 −0

Conversation

duncanmcclean
Copy link
Member

This pull request fixes an issue with Keyed Array fields, where null values were being saved, instead of being filtered out, like they should be.

Fixes #11074.
Caused by #10467.

jasonvarga
jasonvarga requested changes Nov 21, 2024
View reviewed changes
Copy link
Member

@jasonvarga jasonvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests to tests/Fieldtypes/ArrayTest.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonvarga jasonvarga jasonvarga requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Globals in an array type(?) are being saved as null from the UI if no value is specified
2 participants
@duncanmcclean @jasonvarga