Wait for authentication to complete before you can save a cell #1785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pastuxso
changed the title
pastuxso
force-pushed
the
cris/saving-unauth-cells
branch
3 times, most recently
from
5c05ee0 to
1a7d442
Compare
pastuxso
force-pushed
the
cris/saving-unauth-cells
branch
from
1a7d442 to
c481e71
Compare
pastuxso
force-pushed
the
cris/saving-unauth-cells
branch
from
1785fd3 to
ddf8e92
Compare
pastuxso
force-pushed
the
cris/saving-unauth-cells
branch
from
ddf8e92 to
3e847e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update ensures that users must complete the authentication process before saving a cell. It improves reliability by handling authentication state transitions seamlessly during cell run, enhancing the user experience.
It now makes its best effort to wait for the user to complete the happy path, keeping the save button in a loading state. If authentication is completed within a minute, the cell is saved automatically without requiring the user to press save again. If authentication fails, the user is notified, and the save button returns to its initial state.
wait-login.mp4