Add sign-out event handling and panel HTML refresh for CloudPanel #1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pastuxso
commented
Nov 13, 2024
pastuxso
commented
- Implemented emitPanelEvent in Kernel to emit specific events to panels.
- Added signOut event handling in CloudPanel, which clears the app token and refreshes the panel HTML.
- Updated extension.ts to emit signOut event when appropriate, aligning session management behavior.
- Implemented emitPanelEvent in Kernel to emit specific events to panels. - Added signOut event handling in CloudPanel, which clears the app token and refreshes the panel HTML. - Updated extension.ts to emit signOut event when appropriate, aligning session management behavior.
pastuxso
force-pushed
the
cris/cloud-panel-hydrate
branch
from
3e22893 to
7b7dd55
Compare
sourishkrout
requested changes
Nov 18, 2024
There was a problem hiding this comment.
Please review&merge #1803 ahead of merging this PR.
No additional review required.
sourishkrout
added a commit
that referenced
this pull request
Dec 12, 2024
…session management (#1822) * Work in progress * Creating singleton * Singletonization * Sync repo * Sync tests * Reapply "Add sign-out event handling and panel HTML refresh for CloudPanel (#1789)" This reverts commit 0f76025. * Add AuthSessionChangeHandler to prevent multiple listener calls * Passing tests * Remove internal usage of the context from the AuthSessionChangeHandler * Branch sync * Removing kernel and RunmeUriHandler dependencies. * Decrease debounce time * Silently asks If there is a session for CloudPanel * No more silence on error * COde cleanup * Removes unnecessary code * Implementing new argument for silent token * Rollback reactive approach, it’s not working According to the docs, the value (webview) is not being emmited, it’s because the subscription should be settled before the call of the .next() function I need help on it. * Test failling * Rollback panel getAppToken * Passing tests * Cleanup * Minor variable change * Renamed `getSession` to `currentSession` for better clarity. - Refactored `ensureSession` to operate as an instance method instead of static. - Removes unnecessary code * Remove token retrieval from `getHydratedHtml` to prevent double authentication * repository sync * Remove getPlatformAuthSession function * Updates tests * Minor fix * Emit `signIn` event to update panel when login is triggered externally * Use cloud over platform * Fix tests --------- Co-authored-by: Sebastian Tiedtke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.