Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrations/Embed does not generate a correct embed snippet #15

Open
mgornick opened this issue Oct 4, 2016 · 3 comments
Open

Integrations/Embed does not generate a correct embed snippet #15

mgornick opened this issue Oct 4, 2016 · 3 comments

Comments

@mgornick
Copy link

mgornick commented Oct 4, 2016

Observed: When generating the embed link, the page shows a permanent "Loading..." title and the embed snippet contains text for "undefined" which does not work when embedded on another page.

Steps to replicate:

  1. Click on a stat
  2. Click on the Integrations button
  3. Note that the page does not appear to fully load. The H2 still shows "Loading..."
  4. The embed HTML code generates the following snippet line which does not work.
<script>StatHatEmbed.render({s1: 'undefined', w: 760, h: 235});</script>
  • There does not appear to be any JS errors on the page
  • Tested on latest version of Chrome and Safari

Expected Result: The embed page should generate the proper embed snippet for the displayed graph.

@mattgodbolt
Copy link

Wow; three months and no reply? i just hit this too. I like StatHat and was hoping to expose some cool stats to my users using this; but no amount of page reload/trying-to-guess-what the "undefined" value should be works. @stathat please comment, or at least acknowledge this!

@stathat
Copy link
Collaborator

stathat commented Jan 23, 2017

@mgornick @mattgodbolt Sorry for the issue. We haven't been able to reproduce this so far.

Could you please email support@stathat with an account + stat ID that shows 'undefined' for s1?

Thanks.

@mattgodbolt
Copy link

Done! Thanks for the reply 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants