Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge() func incorrect #2

Open
dimakuv opened this issue May 27, 2013 · 0 comments
Open

Merge() func incorrect #2

dimakuv opened this issue May 27, 2013 · 0 comments

Comments

@dimakuv
Copy link

dimakuv commented May 27, 2013

Hello!

There is a bag in your Merge() func, treap.go, line 197:

  • result.left = t.Merge(x, left)
  • result.left = t.Merge(left, x)

You forgot to switch arguments places. Your implementation tried to merge the "right.left with left" instead of "left with right.left".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant