Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Better non-global item filtering #29

Open
staticf0x opened this issue Sep 24, 2023 · 1 comment
Open

Feature: Better non-global item filtering #29

staticf0x opened this issue Sep 24, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@staticf0x
Copy link
Owner

What are you trying to achieve?
We need to be able to identify non-global items but exclude them from the results. They must appear in the result table as an error (or rather something visually different).

Describe the solution you'd like
Instead of ignoring the items completely, we may enable:

  • Jewels
  • Malachai's Vision
  • Blood of Corruption

What have you tried already?

Additional info
This might decrease accuracy on existing items. For this reason, there should be some logic to prefer non-global drops.

@staticf0x staticf0x added the enhancement New feature or request label Sep 24, 2023
@staticf0x staticf0x added this to the v0.6.0 milestone Sep 24, 2023
@staticf0x
Copy link
Owner Author

Cameria's Avarice and Cameria's Maul are two good examples of why this is problematic, they have the exact same image, so they'll have the same min_val.

@staticf0x staticf0x removed this from the v0.6.0 milestone Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant