Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

degreedist.egor() trips for prob=FALSE #82

Closed
mbojan opened this issue Jun 17, 2024 · 2 comments · Fixed by #84
Closed

degreedist.egor() trips for prob=FALSE #82

mbojan opened this issue Jun 17, 2024 · 2 comments · Fixed by #84
Assignees
Labels

Comments

@mbojan
Copy link
Member

mbojan commented Jun 17, 2024

Function degreedist() trips if prob is FALSE:

library(ergm.ego)
data("faux.mesa.high", package="ergm")
fmh <- as.egor(faux.mesa.high)
degreedist(fmh, plot=TRUE, prob=FALSE)
#> Error in degreedist.egor(fmh, plot = TRUE, prob = FALSE): object 'maxfreq' not found

but only if by=NULL because this works:

degreedist(fmh, plot=TRUE, prob=FALSE, by="Sex")
@mbojan mbojan added the bug label Jun 17, 2024
@mbojan mbojan self-assigned this Jun 17, 2024
@martinamorris
Copy link
Member

This needs a code fix, right?

mbojan added a commit that referenced this issue Jun 18, 2024
@mbojan
Copy link
Member Author

mbojan commented Jun 18, 2024

This needs a code fix, right?

Yes. I fixed it, but the checks started to fail for some other reason... I'm looking into it.

mbojan added a commit that referenced this issue Jun 20, 2024
... for relevant argument configurations (prob, by, brgmod).
References #82.
mbojan added a commit that referenced this issue Jun 20, 2024
mbojan added a commit that referenced this issue Jun 20, 2024
... for relevant argument configurations (prob, by, brgmod).
References #82.
mbojan added a commit that referenced this issue Jun 20, 2024
References #82.
@mbojan mbojan linked a pull request Jun 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants