Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arc crashes when trying to delete a file with a :skipped transform #280

Open
OvermindDL1 opened this issue May 31, 2019 · 1 comment · May be fixed by #286
Open

arc crashes when trying to delete a file with a :skipped transform #280

OvermindDL1 opened this issue May 31, 2019 · 1 comment · May be fixed by #286

Comments

@OvermindDL1
Copy link

Environment

  • Elixir version (elixir -v): OTP21 Elixir 1.8.0
  • Arc version (mix deps): 0.11.0
  • Arc dependencies when applicable (mix deps): arc_ecto is 0.11.1
  • Operating system: RedHat

Expected behavior

Deleting a file (specifically done through arc_ecto but ditto when calling to delete it directly) while using a :skip transform should not crash

Actual behavior

Deleting a file (specifically done through arc_ecto but ditto when calling to delete it directly) while using a :skip transform crashes the process and thus the phoenix connection due to the task crashing propagating to it due to trying to delete a nil file. Stacktrace:

2019-05-31:11:50:48.163 [error] Task #PID<0.26883.0> started from #PID<0.26863.0> terminating
** (FunctionClauseError) no function clause matching in IO.chardata_to_string/1
    (elixir) lib/io.ex:461: IO.chardata_to_string(nil)
    (elixir) lib/path.ex:521: Path.do_join/3
    (elixir) lib/path.ex:514: Path.join/2
    (elixir) lib/path.ex:483: Path.join/1
    (ccc_server) lib/arc/storage/fixed_local.ex:31: Arc.Storage.FixedLocal.delete/3
    (elixir) lib/task/supervised.ex:90: Task.Supervised.invoke_mfa/2
    (elixir) lib/task/supervised.ex:35: Task.Supervised.reply/5
    (stdlib) proc_lib.erl:249: :proc_lib.init_p_do_apply/3
Function: #Function<0.46176319/0 in Arc.Actions.Delete.async_delete_version/3>
    Args: []

This makes it impossible to delete those files and is also crashing connections that try it.
@ali7enkish
Copy link

I am also getting this issue. Is there any temporary workaround this?

@dmarkow dmarkow linked a pull request Jul 18, 2019 that will close this issue
Open
@achempion achempion mentioned this issue Sep 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bypass delete on skipped versions dmarkow/arc
2 participants
@OvermindDL1 @ali7enkish