-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
open link to a deck board/card directly in the deck app #498
Comments
If i understood you correct, the link must propose to open links beginning with the protocol
This is possible, but who uses this kind of link? The greates user experience would be to detect a link with the part Therefore your proposed solution would work but, well, where are such links used? |
I don't know how to solve it, but I think if User A sends a board or card link to User B via Chat or Mail and User B opens the link on mobile it would be nice if the deck app opens an not the browser. |
🤷♂️ Maybe one can create intent-filters dynamically at runtime (when we know the hosts). Any help, hints and PRs appreciated. |
This comment has been minimized.
This comment has been minimized.
interesting. Will this not open a app chooser everytime one clicks any link? |
No, because it will only open the app chooser if the pattern matches, which is the pattern that you told him to look for: in this case the link must be a http or https link and contain |
Aah, i got it. Will have a look at it, thanks for the hint! |
btw: links from the deck app seems to contain always the following: But you should make sure that all links contain that pattern yourself. |
Actually, to make it also in multiuser-environments right, the following is maybe helpful: Although I have to say, that point 4 and 5 were differently implemented: the app always presents an account chooser, if more than one account matching the domain was found. And point 3 wasn't completely implemented: it doesn't open the browser if no username was found matching the domain. There was a discussion about it, but it was decided to not implement it in this PR: Instead of opening the link in the browser, you could also decide to ask the user, if they want to create an account... |
The sync step is necessary in order to make sure that the board hasn't shared recently with the user. I would handle it similar to receiving push notifications: We open an activity with a button "Open in browser" and a disabled button "Open in app" which gets only enabled as soon as we are sure we have a user with access permission. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
actually this wouldn't work: <data android:scheme="http"
android:scheme="https"
android:host="*"
android:pathPattern=".*/apps/deck/.*"
/> What will work though is: <data android:scheme="http" />
<data android:scheme="https" />
<data android:host="*" />
<data android:pathPattern="/.*apps/deck/..*" /> |
…thod signatures to SyncManager
I think I'm done here, but I couln't test it yet (no UI). If it dies, just tell, gonna be fixed. |
Okay, i think i have a proof of concept in PR #563 |
Wait, so, is this supposed to be working or not? If i get a notification with nextcloud services with a link to the relevant card, should that link be opening the deck app? because right now its just opening firefox. I've been really struggling with lack of notifications for deck and this would solve my issue. |
Since this is still an open Pull Request, this has not been merged yet and is therefore not supposed to work. |
Is your feature request related to a problem? Please describe.
If I click on a deck link the browser pops up
Describe the solution you'd like
Open it directly in the deck app
It's working for the android file app and it's super convenient:
nextcloud/android#5345
ToDo
SyncManager#readAccountsForHostWithReadAccessToBoard
@desperateCoderIntentFilter
inAndroidManifest
Activity
to pick the correctAccount
to useThe text was updated successfully, but these errors were encountered: