bravura-installer.iss fails with error: Could not read "Z:\git\bravury\redist\OFL.txt" Error: The system cannot find the path specified

[viyengar96]

System: Windows 11 x64
Repro steps:

1. Clone bravura repo: git clone https://github.com/steinbergmedia/bravura.git
2. Download inno setup https://jrsoftware.org/isdl.php#stable (version at the time is 6.2.2)
3. Open {repo}/installers/windows/bravura-installer.iss in Inno Setup
4. Generate new GUID via Inno Setup -> click Tools | Generate GUID inside the IDE.
5. Paste GUID in place of AppID value
6. Run bravura-installer.iss

The setup script seems to be expecting some sort of LicenseFile, but it does not exist in the newly cloned repo. This LicenseFile also doesn't seem to be used in the setup script anywhere; I was able to circumvent the issue by removing the parameter completely from the script. Seems this removal should be echoed in the master branch to prevent future hiccups.

[dspreadbury]

Thanks for this report, Varun. If you'd like to propose an amendment, please feel free to create a pull request and we'll consider mering it.

[viyengar96]

git push --set-upstream origin user/viyengar96/fix-startup-script
remote: Permission to steinbergmedia/bravura.git denied to viyengar96.
fatal: unable to access 'https://github.com/steinbergmedia/bravura.git/': The requested URL returned error: 403

could you please provide permissions for me to create a branch/ merge into main?

[LiberalArtist]

@viyengar96, it looks like you are trying to push to the https://github.com/steinbergmedia/bravura.git repository, for which you presumably do not have write permissions. With GitHub in general, you will first need to "fork" the upstream repository using the GitHub UI, which will create a repository like https://github.com/viyengar96/bravura.git in your user namespace. You would then push your changes to a branch of your forked repository, then create a "pull request" (again through the GitHub UI) proposing to merge your changes upstream.