This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Use txnbuild #205
Merged
Use txnbuild #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhilsaraf
reviewed
Jul 30, 2019
There was a problem hiding this comment.
reviewed most of the files. mostly looks good -- will look at the last few files remaining soon.
this review has more changes than I was expecting so it's taking a little longer -- although they all seem warranted so thanks for make these changes. will try and take a look at the rest of the files as soon as possible but it will likely be after the kelp hackathon is kicked off this week because there's a lot of stuff to be done before I can kick that off.
Added a few comments inline about pointers, rest looks good so far.
|
No worries, please take your time. It is essential that the changes do not introduce any bugs so it is a good call to delay on this a bit till you have more bandwidth. |
…cture It was invalid because it was fetch before it existed and therefore was incomplete.
nikhilsaraf
reviewed
Aug 30, 2019
nikhilsaraf
reviewed
Aug 30, 2019
avoids threading errors through in this situation where really there should be no reason for an error from the delete offer op, althrough ideally we should thread the error through
nikhilsaraf
reviewed
Aug 30, 2019
nikhilsaraf
reviewed
Aug 30, 2019
nikhilsaraf
reviewed
Aug 30, 2019
nikhilsaraf
reviewed
Aug 30, 2019
nikhilsaraf
reviewed
Aug 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #269
This PR covers part of the work required to update Kelp to use the new stellar Go sdk. This PR focuses on changing the transaction builder package from
buildtotxnbuild.This PR also changes the usage of
clients/horizonin some places that could not be changed in #204. In particular, these two files were changed.../gui/backend/upsert_bot_config.go
.../gui/backend/autogenerate_bot.go
With these changes, Kelp should not have any instance of the deprecated
buildandclients/horizonpackages.This PR is based off the branch in #204, please review that before this.
Nikhil's list of outstanding issues to check:
baseAmountandquoteAmountnumbers that are divided by 10^7. Example:0.00015000instead of1500.0000000when the other log lines use the correct value of1500.0000000txnbuild.Operationreferences inapi/*so we don't bump major version number and create a new PR for this API change to be merged later