Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIKE] Investigate converting SDS to react-native-web #1679

Open
piyalbasu opened this issue Nov 15, 2024 · 1 comment
Open

[SPIKE] Investigate converting SDS to react-native-web #1679

piyalbasu opened this issue Nov 15, 2024 · 1 comment
Assignees

Comments

@piyalbasu
Copy link
Contributor

piyalbasu commented Nov 15, 2024

We're looking to build Freighter Mobile and one of our optimistic goals is to generate a mobile version from the existing codebase. The theory is if we can repurpose the current UI for the mobile version, we'd just have to swap in a different data store for mobile. This would allow is to only have build UI elements once and keep parity between web and mobile. A multiplatform React framework called react-native-web could help us do this.

In our last look at this, we discovered one of the main stumbling points is that SDS does not play well with react-native-web. We would basically need to re-write all of our existing SDS styles into react-native-web compatible styles, which defeats the purpose of using our current UI

Acceptance Criteria

Let's look at what the effort is to convert SDS v3 to react-native-web.

  • What are our constraints? react-native-web won't be able to support everything int he current SDS. For example, more complex UI elements that use animations libraries, dynamically positioned elements, etc. may not be supported. Can we get a better understanding of what we can't do? If this adds constraints to what we can use in web, are we okay with that trade-off? SDS is used across multiple teams: would others be okay with introducing constraints?
  • How long would it take to convert SDS v3 to react-native-web? Is it complex work or just tedious?
@aristidesstaffieri
Copy link
Contributor

Some of the artifacts from the last time we did a spike on this -

RFC - https://docs.google.com/document/d/1x2kFhhvJOYUBxRAppvt0OBpywpJCwjL046KID8RKfqE/edit?usp=sharing
Research - https://docs.google.com/document/d/1nuuZ9NvkbpxiidOQlIlqpp4vza41J3pxk5NdD_ZQzeU/edit?usp=sharing
POC - https://github.com/stellar/freighter/tree/feature/react-native-poc - (this is going to be very far behind the tip of master but should show the attempted changes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants