Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify authorizeEntry's callback signature to return both the signature and the publicKey. #780

Closed
Shaptic opened this issue Sep 18, 2024 · 1 comment · May be fixed by #783
Closed

Modify authorizeEntry's callback signature to return both the signature and the publicKey. #780

Shaptic opened this issue Sep 18, 2024 · 1 comment · May be fixed by #783
Assignees
@Shaptic
Labels
breaking-change Protocol 22 rpc-sdk-scrum Align with Platform's RPC/SDK planning board
Milestone
platform sprint 54

Comments

@Shaptic
Copy link
Contributor

Shaptic commented Sep 18, 2024

This will give users more flexibility in multi-sig scenarios when the address on the entry is not the same as the address that signs the entry.

Originally posted by @overcat in #772 (comment)
@Shaptic Shaptic mentioned this issue Sep 18, 2024
Merged
@Shaptic Shaptic self-assigned this Sep 18, 2024
@Shaptic Shaptic added the rpc-sdk-scrum Align with Platform's RPC/SDK planning board label Sep 18, 2024
@Shaptic Shaptic added this to the platform sprint 51 milestone Sep 18, 2024
@Shaptic Shaptic moved this from Backlog to To Do in Platform Scrum Sep 18, 2024
@overcat overcat mentioned this issue Sep 19, 2024
Merged
@Shaptic Shaptic mentioned this issue Nov 13, 2024
Open
@mollykarcher mollykarcher reopened this Dec 3, 2024
@Shaptic
Copy link
Contributor Author

Shaptic commented Dec 3, 2024

Closed by #783

@Shaptic Shaptic closed this as completed Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shaptic Shaptic

Labels
breaking-change Protocol 22 rpc-sdk-scrum Align with Platform's RPC/SDK planning board
Projects
Platform Scrum
Status: Done
Milestone
platform sprint 54
Development

Successfully merging a pull request may close this issue.

Extend SigningCallback form to allow returning an object stellar/js-stellar-base
2 participants
@Shaptic @mollykarcher