Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include diagnostic events on soroban enabled core logging #436

Closed
sreuland opened this issue Mar 24, 2023 · 0 comments · Fixed by #435
Closed

Include diagnostic events on soroban enabled core logging #436

sreuland opened this issue Mar 24, 2023 · 0 comments · Fixed by #435
Assignees
@paulbellamy @sreuland
Labels
soroban-scrum

Comments

@sreuland
Copy link
Contributor

sreuland commented Mar 24, 2023 •
edited
Loading

What problem does your feature solve?

quickstart doesn't configure soroban enabled core to log diagnostic events by default.

What would you like to see?

as part of diagnostic events release - stellar/stellar-cli#471
ability to toggle with a command line flag the soroban enabled core diagnostic events output

What alternatives are there?

configure soroban enabled core to log diagnostic events by default, no flag needed
This was referenced Mar 24, 2023
Closed
Merged
sreuland added a commit that referenced this issue Mar 24, 2023
@sreuland
#436: chip in on pr feedback
6c9a2e1
@sreuland sreuland moved this from Backlog to Needs Review in Platform Scrum Mar 26, 2023
sreuland added a commit that referenced this issue Mar 26, 2023
@sreuland
#436: removed gh workflow caching on horizon/friendbot image builds, …
4fbd833 
…cache key based on source branch ref was not invalidating the horizon/friendbot build image cache key when branch had new commits
sreuland added a commit that referenced this issue Mar 26, 2023
@sreuland
#436: put the core git ref back to last soroban release, can't bump t…
1d008c1 
…hat to latest yet, go:soroban-xdr-next doesn't have that latest xdr yet
paulbellamy pushed a commit that referenced this issue Mar 27, 2023
Revert "#436: put the core git ref back to last soroban release, can'…
742c852 
…t bump that to latest yet, go:soroban-xdr-next doesn't have that latest xdr yet"

This reverts commit 1d008c1.
@github-project-automation github-project-automation bot moved this from Needs Review to Done in Platform Scrum Mar 28, 2023
paulbellamy pushed a commit that referenced this issue Mar 28, 2023
@sreuland
Add --enable-soroban-diagnostic-events flag (#435)
457f514 
* Add `--enable-soroban-diagnostic-events` flag

* #436: chip in on pr feedback

* debug friendbot startup problem, adding more logging to test

* #436: removed  gh workflow caching on horizon/friendbot image builds, cache key based on source branch ref was not invalidating the horizon/friendbot build image cache key when branch had new commits

* #436: put the core git ref back to last soroban release, can't bump that to latest yet, go:soroban-xdr-next doesn't have that latest xdr yet

* Revert "#436: put the core git ref back to last soroban release, can't bump that to latest yet, go:soroban-xdr-next doesn't have that latest xdr yet"

This reverts commit 1d008c1.

* removed caching from the soroban build of rpc server to avoid missing builds on commit changes for branch refs

---------

Co-authored-by: Shawn Reuland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulbellamy paulbellamy

@sreuland sreuland

Labels
soroban-scrum
Projects
Platform Scrum
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add --enable-soroban-diagnostic-events flag stellar/quickstart
2 participants
@paulbellamy @sreuland