Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example to work with value overhaul #92

Closed
2 tasks
tsachiherman opened this issue Mar 6, 2023 · 2 comments · Fixed by #93
Closed
2 tasks

Update example to work with value overhaul #92

tsachiherman opened this issue Mar 6, 2023 · 2 comments · Fixed by #93
Assignees
Labels
soroban-scrum A label to make relevant issues appear in the Platform Scrum board.

Comments

@tsachiherman
Copy link

tsachiherman commented Mar 6, 2023

Epic

stellar/stellar-cli#471


What?

TL;DR: Update example to work with the ScVal overhaul.

This involves work across most of the dApp, but each item should be a fairly straightforward adaptation. A lot of the ScVal stuff is abstracted away, so fixing that abstraction is the bulk of the work:

@Shaptic
Copy link
Contributor

Shaptic commented Mar 9, 2023

@tsachiherman this is normally handled by the Core team (see the commit history); did you mean for this to apply to https://github.com/stellar/soroban-example-dapp/?

@tsachiherman
Copy link
Author

@tsachiherman this is normally handled by the Core team (see the commit history); did you mean for this to apply to https://github.com/stellar/soroban-example-dapp/?

you're correct @Shaptic; I meant it to be soroban-example-dapp. I'll update that.

@tsachiherman tsachiherman transferred this issue from stellar/soroban-examples Mar 9, 2023
@mollykarcher mollykarcher moved this from Backlog to Current Sprint in Platform Scrum Mar 20, 2023
@Shaptic Shaptic self-assigned this Mar 23, 2023
@Shaptic Shaptic moved this from Current Sprint to In Progress in Platform Scrum Mar 23, 2023
@paulbellamy paulbellamy assigned paulbellamy and unassigned Shaptic Mar 28, 2023
@paulbellamy paulbellamy moved this from In Progress to Blocked in Platform Scrum Mar 29, 2023
@paulbellamy paulbellamy added the soroban-scrum A label to make relevant issues appear in the Platform Scrum board. label Mar 29, 2023
@github-project-automation github-project-automation bot moved this from Blocked to Done in Platform Scrum Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
soroban-scrum A label to make relevant issues appear in the Platform Scrum board.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants