Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soroban-rpc: wildcard filtering, make sure equality works as expected with all the new ScVal structs in getEvents #477

Closed
tsachiherman opened this issue Mar 6, 2023 · 3 comments · Fixed by #523
Assignees

Comments

@tsachiherman
Copy link
Contributor

tsachiherman commented Mar 6, 2023

What ?

soroban-rpc: wildcard filtering, make sure equality works as expected with all the new ScVal structs in getEvents

The equality operator is actually implemented in the go monorepo so the only work required on the soroban-rpc side is updating the unit tests and making sure they still work.

Epic

#471

@2opremio
Copy link
Contributor

@tsachiherman Let me know if you think the work stellar/go#4812 is enough to close this ticket

@tamirms
Copy link
Contributor

tamirms commented Mar 16, 2023

@2opremio I think we need to update these tests https://github.com/stellar/soroban-tools/blob/main/cmd/soroban-rpc/internal/methods/get_events_test.go once the xdr files have been updated in the monorepo

@mollykarcher mollykarcher moved this from Backlog to Current Sprint in Platform Scrum Mar 20, 2023
@paulbellamy
Copy link
Contributor

paulbellamy commented Mar 20, 2023

ScVal.Equals was fixed in stellar/go#4815, so we just need to update the go.mod and tests and check it in soroban-rpc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants