Add fee support #632
Merged
Add fee support #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Try new docker compose plugin (#631) * Try new docker compose plugin * Ok we need to add the docker apt repo :( * Need an apt-get update * Force-install docker-compose * Remove old docker-compose first? * try removing moby-compose * Clean up workflow * Add meta output to soroban-cli contract inspect output (#620) * Add env_meta output to soroban-cli contract inspect output * Output contract meta and improve contract inspect formatting * Indent the docs to match * rustfmt * Improve function inspect output * improving the inspect output formatting * handle lib in inspect output * Satiate clippy --------- Co-authored-by: Tsachi Herman <[email protected]> --------- Co-authored-by: Paul Bellamy <[email protected]>
* Create Skeletton to calculate soroban transaction data in libpreflight * Calculate transaction data a minimum fee in libpreflight * Calculate transaction data a minimum fee in libpreflight * Make integration tests compilable again * Assume missing entries from ledger storage are created * Update simulate transaction integration tests * Add TODOs for the integration tests to pass * Make events global * Address review feedback * Add TODO about taking into account the Auth size * Add a few more TODOs and debug info * First attempt and preflighting all transactions * Always take into account keys when computing unmodified ledgers * Come up with the minimum fee to add in order to make it work * Fix transaction_resources computation * Remove debug printout * Increase instruction leeway * Fix the rest of the simulate transaction test * Fix remaining intgeration tests * Address review feedback * Tweak the instruction estimation further * Address review feedback * Fix tests again * Obtain auth data per function * Take auth data into account for estimating envelope size * Split up libpreflight in multiple modules and improve the storage code * Fix TODO * Remove another TODO * Remove yet another TODO * Appease clippy * update * update core version * make sure to test multiple host functions invocations. --------- Co-authored-by: Tsachi Herman <[email protected]>
…cli/env flags, ordering of config value application was modified to default->env/cli->file path.
tsachiherman
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add support for fee upstream feature
Why
#519
Known limitations
N/A