Handle resplay for feebumptransactionframe

stellar · Nov 19, 2024 · 42242c0 · 42242c0
1 parent d6041b4
commit 42242c0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/src/transactions/MutableTransactionResult.cpp b/src/transactions/MutableTransactionResult.cpp
@@ -485,21 +485,18 @@ FeeBumpMutableTransactionResult::setReplayFailingTransactionResult(
     TransactionResult const& failing)
 {
     // no-op
-    // TODO maybe this should be no-op
-    mReplayFailingTransactionResult = std::make_optional(failing);
 }
 
 std::optional<TransactionResult> const&
 FeeBumpMutableTransactionResult::getReplaySuccessfulTransactionResult() const
 {
-    // no -op?
-    return mReplaySuccessfulTransactionResult;
+    return std::nullopt;
 }
 
 std::optional<TransactionResult> const&
 FeeBumpMutableTransactionResult::getReplayFailingTransactionResult() const
 {
-    return mReplayFailingTransactionResult;
+    return std::nullopt;
 }
 
 }
diff --git a/src/transactions/TransactionFrame.cpp b/src/transactions/TransactionFrame.cpp
@@ -1581,7 +1581,6 @@ TransactionFrame::applyOperations(AbstractSignatureChecker& signatureChecker,
     {
         // Sub-zone for skips
         ZoneScopedN("skipped failed");
-
         txResult.setResultCode(failingResult->result.code());
         txResult.getResult().result.results() = failingResult->result.results();
         return false;