Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Soroban upgrade script #3863

Closed
5 tasks
sisuresh opened this issue Jul 31, 2023 · 5 comments
Closed
5 tasks

Improve Soroban upgrade script #3863

sisuresh opened this issue Jul 31, 2023 · 5 comments
Assignees

Comments

@sisuresh
Copy link
Contributor

sisuresh commented Jul 31, 2023

  • Specify which settings to upgrade with a better UX than updating the hardcoded setting in the script. Maybe a JSON file with the upgrades will work well.
  • Update the network used (futurenet vs standalone vs pubnet) on the command line.
  • Fund the source account with friendbot if it doesn't exist.
  • Add an endpoint in stellar-core that takes a proposed ConfigUpgradeSetKey and returns what the upgrade diff will be.
  • Remove dependency on python SDK and build transactions in stellar-core. (Added after the issues we had on 9/15)
@sisuresh
Copy link
Contributor Author

sisuresh commented Aug 1, 2023

Related to #3822

@leighmcculloch
Copy link
Member

This issue is a blocker for the following issue that is impacting contract developers today:

@leighmcculloch
Copy link
Member

  • build transactions in stellar-core

It would be convenient to have this in stellar-core, but also since the lack of this script is causing problems today, and the next release of stellar-core is not for sometime, it would be ideal if we build this tool behavior into its own tool that we could ship today/soon.

@leighmcculloch
Copy link
Member

This issue is a blocker for the following feature issue:

@sisuresh
Copy link
Contributor Author

This issue is about improving the Python upgrade script (which we're going to get rid of). I'm closing it issue in favor of #3822.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@leighmcculloch @sisuresh and others