-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update overlay survey script to support new time sliced survey #4302
Comments
Just double checking here: there is no dependency between this issue and #4275, because we'd still support old-style survey, so the script can be updated whenever we're ready to run/test survey V2, right? |
Yes, that's right. #4275 leaves the old survey interface intact so there's no need to immediately update the script. |
Quick note here: I bumped priority of this issue to P0, since we'd need the new script to test survey v2 (ideally, we can do this during RC stage of our v21.1.0 release process to catch any issues before bumping to stable) |
Good point. At this point I don't think the HTTP interfaces in #4275 will change significantly (if at all), so I'll start working on updating the script. |
Resolves stellar#4302 This change updates the network overlay survey script to support the new V2 survey API. To test this, I also updated the simulator to simulate the new API, then I checked that the resulting graph from simulating an old pubnet survey is structurally isomorphic to the input graph. I also checked that the new fields are present in the output graph.
#4275 adds a new time sliced survey mechanism with new HTTP endpoints for running a survey. We should update the python script to use the new endpoints.
The text was updated successfully, but these errors were encountered: