De-dupe inbound SCP traffic #4544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marta-lokhova
force-pushed
the
overlayPerfSCPMsg
branch
2 times, most recently
from
a70db72
to
96dfd0a
Compare
marta-lokhova
force-pushed
the
overlayPerfSCPMsg
branch
from
96dfd0a
to
fa043c9
Compare
bboston7
suggested changes
Nov 19, 2024
marta-lokhova
force-pushed
the
overlayPerfSCPMsg
branch
3 times, most recently
from
6757bde
to
f1b8c80
Compare
graydon
requested changes
Nov 21, 2024
marta-lokhova
force-pushed
the
overlayPerfSCPMsg
branch
3 times, most recently
from
791f3e5
to
cc567b6
Compare
graydon
previously approved these changes
Nov 21, 2024
marta-lokhova
force-pushed
the
overlayPerfSCPMsg
branch
from
cc567b6
to
dc4ad77
Compare
graydon
approved these changes
Nov 21, 2024
bboston7
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary goal of this change is to reduce burden on the main thread scheduler by hashing and de-duping inbound SCP traffic. In simulations, we've observed duplicate SCP message consume quite a bit of main thread/scheduler capacity. With this change, the amount of duplicate SCP traffic core processes is reduced by ~50%. Another small change in this PR is to broadcast SCP messages immediately instead of scheduling them asynchronously - SCP traffic is high priority, so there's no reason to delay it like we do in master.
Attaching scheduler load comparison plus duplicate traffic inbound rate for comparison