[Soroban] Storage example documentation inconsistecy

[lijamie98]

What version are you using?

Stellar CLI 22.1.0

What did you do?

In this page: https://developers.stellar.org/docs/build/smart-contracts/getting-started/storing-data

The stellar contract init ./ --with-example increment is no longer available.

error: invalid value 'increment' for '--with-example <WITH_EXAMPLE>': This argument has been removed and will be not be recognized by the future versions of CLI: Adding examples via cli is no longer supported. You can still clone examples from the repo https://github.com/stellar/soroban-examples

For more information, try '--help'.

The documents code: env.storage().instance().extend_ttl(100, 100); is inconsistent with the example.

// The contract instance will be bumped to have a lifetime of at least 100 ledgers if the current expiration lifetime at most 50.
// If the lifetime is already more than 100 ledgers, this is a no-op. Otherwise,
// the lifetime is extended to 100 ledgers. This lifetime bump includes the contract
// instance itself and all entries in storage().instance(), i.e, COUNTER.
env.storage().instance().extend_ttl(50, 100);

What did you expect to see?

Consistency

What did you see instead?

Inconsistency

[ElliotFriend]

1. We should remove all instances of --with-example from the stellar contract init ... command examples/snippets. I don't know for sure how frequent the occurrences are, or where they are, we should search through the /docs folder to look for any to fix.
2. The contract's code is here: https://github.com/stellar/soroban-examples/blob/main/increment/src/lib.rs. imo, we don't necessarily need to copy the whole contents of the file (specifically the long comment above the extend ttl function), but we should make sure the actual code (the arguments to the extend ttl function) reflect what's in the source code.