Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to enable non-root auth in simulation #344

Open
dmkozh opened this issue Dec 23, 2024 · 2 comments
Open

Allow users to enable non-root auth in simulation #344

dmkozh opened this issue Dec 23, 2024 · 2 comments

Comments

@dmkozh
Copy link
Contributor

dmkozh commented Dec 23, 2024

What problem does your feature solve?

Currently simulation by default disallows 'non-root' authorization in recording mode, i.e. disallows potentially 'frontrunnable' authorizations. This is a very sensible default setting as most of the time it's correct to make all the calls non-frontrunnable. That said, there is still a range of cases where non-root auth is intentional and thus we need to provide users with a way of enabling this.

What would you like to see?

There should be some request parameter that enables non-root auth. It's fine for this to be not easily discoverable or accessible as this is meant for the advanced users. But there needs to be at least some way of enabling this.

What alternatives are there?

Not providing the users with an option. This basically makes auth simulation unusable for a fraction of the users, which is not desirable.

@dmkozh dmkozh self-assigned this Dec 23, 2024
@dmkozh
Copy link
Contributor Author

dmkozh commented Dec 23, 2024

This requires an env release as well. I'll work on this and assign this to myself for the time being. It would be great if someone else could help with the RPC interface part when the env change is released.

@dmkozh
Copy link
Contributor Author

dmkozh commented Jan 6, 2025

The env-side change has been released in 22.1.3 release (stellar/rs-soroban-env#1503) and it can be now implemented in soroban-rpc at any time now.

It had to be guarded by unstable-next-api feature in order to pass the semver checks, which should be fine to enable in soroban-rpc as we'll be aware of the dependency and will make sure to not accidentally break it (should there be any more API-breaking features before v23 release).

The alternative is to wait until the stable v23 release, though it might be a good idea to at least prepare the change before that.

@dmkozh dmkozh removed their assignment Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant