Next into curr #147
Merged
Next into curr #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defines the 'complete' status check.
* add ENVELOPE_TYPE_CONTRACT_ID_FROM_ASSET * add new HostFunction type and HashIDPreimage for using the source account in the host
* XDR for RestoreFootprintOp * Use extension point instead
…atch new terminology (stellar#114)
- Remove the flat fee - Rename the fields that contribute to the write fee for clarity
- Use dedicated struct for `InvokeContract` host fn - Replace `ScVec` with `SCVal` or `SCVal<>` depending on the context
…lar#127) Also renamed a couple tx-size related fields for clarity.
* Add errors for exceeding the refundable fee. These have to be operation errors, as core is hard-wired to only return `txFAILED` on transaction failure and modifying this behavior is risky/slow. * Remove `contractEventsSizeBytes` from `SorobanResources`. This field is almost redundant and only helps to avoid apply-time error in the rare cases when the user sets the events resource, but forgets to set high enough refundable fee. It does, on the other hand, introduce another apply-time failure condition if the contracts emits a bit more events than expected (even if the refundable fee is high enough to cover that). The total size of the events emitted is still governed by the network setting.
* expand SCError comments, no functional change * Update Stellar-contract.x Co-authored-by: Siddharth Suresh <[email protected]> --------- Co-authored-by: Siddharth Suresh <[email protected]>
Merged
6 tasks
graydon
approved these changes
Sep 8, 2023
Co-authored-by: Graydon Hoare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked as draft because the history includes every commit in next for some reason...Edit: I don't think we have another choice with the merge because there's no common history between the two branches.I had to merge with
git merge --allow-unrelated-histories upstream/nextto get this to work.