NODEJS tests are failing

[leighmcculloch]

What version are you using?

It's difficult to know, because the jobs that use it don't seem to really specify:
https://github.com/stellar/stellar-cli/actions/runs/12319954892/job/34577619594

But it's failing with the latest version as of today.

What did you do?

Run system tests.

What did you expect to see?

Success.

What did you see instead?

--- Failed steps:
  Scenario Outline: DApp developer compiles, deploys and invokes a contract # ./dapp_develop.feature:21
    And The result should be to receive 0 contract events and 1 diagnostic events for soroban-hello-world-contract from NODEJS # ./dapp_develop.feature:29
      Error: 
	Error Trace:	dapp_develop_test.go:230
	            				value.go:596
	            				value.go:380
	            				stepdef.go:182
	            				suite.go:183
	            				suite.go:391
	            				suite.go:447
	Error:      	Not equal: 
	            	expected: 1
	            	actual  : 2
	Messages:   	Expected 1 diagnostic events for soroban-hello-world-contract using NODEJS but got 2

cc @Shaptic

[leighmcculloch]

Started to see failures on the CLI, even on commits that previously passed the system-test. The test failure seems to be NODEJS related, which I assume means the latest js-stellar-sdk has become incompatible with it.

[sreuland]

Yes, newer version of the js sdk had changed exported pkg names which the test js client scripts in here were importing, this was fixed on #114, that is likely the resolution for this ticket, and can close it.