Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Existing tests should pass with newer ScVal model #41

Closed
tsachiherman opened this issue Mar 6, 2023 · 1 comment · Fixed by #47
Closed

Existing tests should pass with newer ScVal model #41

tsachiherman opened this issue Mar 6, 2023 · 1 comment · Fixed by #47
Assignees
@sreuland
Labels
soroban-scrum

Comments

@tsachiherman
Copy link
Contributor

tsachiherman commented Mar 6, 2023 •
edited by sreuland
Loading

What ?

Verify that any references to ScVal in system test are updated to conform to newer ScVal model.
Fix any failures or regressions due to the new ScVal model from core.
Should be able to run system tests against latest version of pre-release core git ref that has newer ScVal and pass.

Epic

stellar/stellar-cli#471
@tsachiherman tsachiherman mentioned this issue Mar 6, 2023
Closed
@sreuland sreuland changed the title system-test: scval building for test helpers will need updating Existing tests should pass with newer ScVal model Mar 10, 2023
@mollykarcher mollykarcher moved this from Backlog to Current Sprint in Platform Scrum Mar 20, 2023
@paulbellamy
Copy link
Contributor

I think the only place we deal with scvals directly in this repo is in invoke.ts

@sreuland sreuland self-assigned this Mar 22, 2023
@sreuland sreuland moved this from Current Sprint to In Progress in Platform Scrum Mar 22, 2023
sreuland added a commit to sreuland/system-test that referenced this issue Mar 23, 2023
@sreuland
stellar#41: fixed cli test to use --source=identity, updated readme
6b19f82
@sreuland sreuland mentioned this issue Mar 23, 2023
Merged
sreuland added a commit to sreuland/system-test that referenced this issue Mar 23, 2023
@sreuland
stellar#41, added docs on js client version
699eb62
@sreuland sreuland moved this from In Progress to Needs Review in Platform Scrum Mar 24, 2023
sreuland added a commit to sreuland/system-test that referenced this issue Mar 24, 2023
@sreuland
stellar#41: fixed typo in readme
79cad5a
@paulbellamy paulbellamy mentioned this issue Mar 24, 2023
Closed
@github-project-automation github-project-automation bot moved this from Needs Review to Done in Platform Scrum Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sreuland sreuland

Labels
soroban-scrum
Projects
Platform Scrum
Status: Done
Milestone
No milestone
3 participants
@paulbellamy @sreuland @tsachiherman