Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New rubocop releases often break build #6

Open
kwauchope opened this issue Mar 22, 2017 · 1 comment
Open

New rubocop releases often break build #6

kwauchope opened this issue Mar 22, 2017 · 1 comment

Comments

@kwauchope
Copy link
Contributor

Sorry @stevenhaddox , just a quick one for you. The biggest headache with new builds is rubocop minor version releases adding new rules which then break the build. This is most annoying when a rubocop release is pushed out while developing so you are using a different development version to what ends up being used in travis and the build breaks when it 'worked on my box'.

I'm far from a ruby dev, I'm not sure your take and a quick google didn't bring up anything as far as resolving this issue but do you think locking to a specific rubocop minor version is a good move? If so it will need to be v0.41 to continue to support ruby 1.9.3, otherwise will have to drop 1.9.3 support and dnc can use a newer rubocop. I'm happy to implement either and put in a pull request.

@stevenhaddox
Copy link
Owner

@kwauchope: I want dnc to be usable across as many rubies as possible. I think locking rubocop to the version it was created against (or the latest you have working with it) is perfectly reasonable if it's not following SemVer in a friendly manner. If you want to modify the Gemfile to lock rubocop I can bump it manually whenever I want to get the latest and greatest community style checks. Happy to accept a PR for that change :)

esabelhaus added a commit that referenced this issue Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants