Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit ff52582 does not build #1

Open
martin-c opened this issue Nov 20, 2019 · 2 comments
Open

Commit ff52582 does not build #1

martin-c opened this issue Nov 20, 2019 · 2 comments

Comments

@martin-c
Copy link
Contributor

martin-c commented Nov 20, 2019

I've identified a few issues with the latest commit ff52582 which prevent it from building:

  1. There's a command line in Makefile.in that's indented with 4 spaces instead of a tab which causes an error when make tries to parse the file.

  2. The header file avr/io.h now has a block surrounded by #if !defined(AVR_LIBC_LEGACY_IO) ... #endif. The problem is that this conditional block skips including avr/common.h (and others) when AVR_LIBC_LEGACY_IO is defined. This causes the compiler to eventually generate an error since AVR_STACK_POINTER_REG in libc/stdlib/stdlib_private.h is no longer defined.

  3. Many of the header files in avr/legacyio refer to common headers which were previously just in the avr directory. For example, iom48.h includes avr/iomx8.h. Since iomx8.h has been moved to legacyio directory this and other include directives fail.

stevenj added a commit that referenced this issue Feb 9, 2020
Fix issue #1: Commit ff52582 does not build, issue #5: Sleep Register Names are Incorrect
@stevenj
Copy link
Owner

stevenj commented Feb 10, 2020

This version is a work in progress, i seriously didn't expect anyone to use it yet. That said, your patches are appreciated. I am currently heavily tied up with work so can't get much time to work on this, but i haven't abandoned it. So if you like to propose patches, i am happy to apply them.

@burnpanck
Copy link

I suggest to follow a branching model like git-flow, which makes it much easier for people to see what is work in progress, and what is deployable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants