-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jazzma/pwc menus #202
Jazzma/pwc menus #202
Conversation
added pwc menu, will add milkshake place later as well. Added dropdown to select between menus. changed colors to match what theme is chosen
Added Special Menu (Poke Bowl, Sushi, Taco, Wings) and Deli menu (Sandwich Bar)
Thanks so much for continuing to work on this new feature! Pretty awesome how you've gathered all of this info and presented it nicely. Will be helpful to a lot of students. Here's some feedback:
Super excited to see this feature grow! Thanks again for setting aside your time :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comment :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my previous comment
wasn't able to change dropdown alignment since the component only allows for 3 alignments (left, right, center) and only one way to roll out - down or up) |
With the dropdown - I was talking about the overall alignment of the actual element itself, as it's a bit jarring just having that as the first item you see on the page. It's meant to be more of a smaller, form element than a giant selector. |
Thanks for fixing the position! However - I'm not sure if a dropdown is the best way to choose the menus, or if the current impl can be revised to make it more user friendly (cc @JosephShepin). Also, the menu is still quite hard to read on mobile - showed this to a few friends and they agreed. May be a good idea to continue playing around with text sizes & orientation on mobile as well. |
Added text to dropdown to match current menu
Fixed styling to work on all devices properly and no extra padding or white space
also matched names to dropdown |
added menus for jazzman's and pwc