Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unexpected keyword argument 'learning_starts' #1

Open
aditink opened this issue Nov 9, 2023 · 2 comments
Open

unexpected keyword argument 'learning_starts' #1

aditink opened this issue Nov 9, 2023 · 2 comments

Comments

@aditink
Copy link

aditink commented Nov 9, 2023

Hi! I am trying to use JSRL with stable baselines 3 PPO.
However, at the line

model = jsrl.get_jsrl_algorithm(PPO)(
    "MultiInputPolicy",
    env,
    policy_kwargs=dict(
        guide_policy=guide_policy,
        max_horizon=max_horizon,
        strategy="curriculum",
        horizons=np.arange(max_horizon, -1, -max_horizon // n,)
    ),
    verbose=1,
    tensorboard_log="logs/pointmaze_jsrl_curriculum"
)

I see the error

  File "XXX/.local/lib/python3.10/site-packages/jsrl/jsrl.py", line 208, in __init__
    super().__init__(policy, *args, **kwargs)
TypeError: PPO.__init__() got an unexpected keyword argument 'learning_starts'
@chengzelei
Copy link

I meet this problem as well.. Probably commenting it will solve this issue

@steventango
Copy link
Owner

Hi thanks for bringing this up and sorry for the delay. I have addressed this TypeError, however, further testing is needed to see if this implementation works properly with on policy algorithms like PPO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants