Fixed package.json#exports.types
#1150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andarist
commented
Apr 3, 2023
| @@ -2,7 +2,6 @@ | |||
| "name": "@stitches/core", | |||
| "version": "1.3.1-1", | |||
| "description": "The modern CSS-in-JS library", | |||
| "type": "module", | |||
There was a problem hiding this comment.
I don't think that you actually needed this. You still provide exports.import after all. Having those packages as modules changes how .js (and this .d.ts) files are treated and supporting types with this setup would be much more complicated. So I think that there is no harm if we just remove this from here to make types work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When relying on
exports.typesfor loading types, this condition has to come first.exportsare order-dependent - tests/loaded from the top to the bottom