Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure under new BH version #4

Open
eddelbuettel opened this issue Dec 14, 2024 · 0 comments
Open

Test failure under new BH version #4

eddelbuettel opened this issue Dec 14, 2024 · 0 comments

Comments

@eddelbuettel
Copy link

As described in issue 103 at the BH repo, we are preparing a new BH release based on the just-release Boost 1.87.0 release. Your package OwenQ failed seven of its tests during reverse-depends checking, I am including the first two here:

* checking tests ... ERROR
  Running ‘testthat.R’
Running the tests in ‘tests/testthat.R’ failed.
Complete output:
  > library(testthat)
  > library(OwenQ)
  > 
  > test_check("OwenQ")
  [ FAIL 7 | WARN 0 | SKIP 0 | PASS 288 ]
  
  ══ Failed tests ════════════════════════════════════════════════════════════════
  ── Error ('test-OwenQ1_algo1.R:14:3'): OwenQ1 is correctly vectorized ──────────
  <boost::wrapexcept<std::domain_error>/C++Error/error/condition>
  Error: Error in function boost::math::erf<long double>(long double): Expected a finite argument but got -nan
  Backtrace:
      ▆
   1. ├─testthat::expect_identical(...) at test-OwenQ1_algo1.R:14:3
   2. │ └─testthat::quasi_label(enquo(object), label, arg = "object")
   3. │   └─rlang::eval_bare(expr, quo_get_env(quo))
   4. └─OwenQ::OwenQ1(nu, t, delta, R)
   5.   └─OwenQ:::RcppOwenQ1(nu, t, delta[i], R[i], algo = algo)
  ── Error ('test-OwenQ1_algo2.R:14:3'): OwenQ1 is correctly vectorized ──────────
  <boost::wrapexcept<std::domain_error>/C++Error/error/condition>
  Error: Error in function boost::math::erf<long double>(long double): Expected a finite argument but got -nan
  Backtrace:
      ▆
   1. ├─testthat::expect_identical(...) at test-OwenQ1_algo2.R:14:3
   2. │ └─testthat::quasi_label(enquo(object), label, arg = "object")
   3. │   └─rlang::eval_bare(expr, quo_get_env(quo))
   4. └─OwenQ::OwenQ1(nu, t, delta, R)
   5.   └─OwenQ:::RcppOwenQ1(nu, t, delta[i], R[i], algo = algo)
  ── Error ('test-OwenQ2_algo1.R:7:25'): OwenQ2 for R=0 equals ptOwen ────────────

Something appears to be different now with respect to NaN values. Can you take a look? The new version of BH is available at R-universe in source and binary.

Please let me know if I can assist in any way, and my thanks in advance for taking a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant